Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenIDConnectClient.php #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

massej
Copy link

@massej massej commented Sep 8, 2023

Fix issue with Azure B2C that already use a parameter.

List of common tasks a pull request require complete

  • Changelog entry is added or the pull request don't alter library's functionality

Fix issue with Azure B2C that already use a parameter.
Copy link
Collaborator

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a unit test on this .....

@massej
Copy link
Author

massej commented Dec 30, 2023

@DeepDiver1975 How to add unit test in this project?

the test case would be https://test.com/user_info_endpoint then it would add ?schema= with a ?

if it’s an url that already has parameter like
https://test.com/user_info_endpoint?policy=b2ctest

then it would add &schema= with the &

@ricklambrechts
Copy link
Contributor

Currently we use this implementation for the auth endpoint, so I think it would be nice to use the same logic instead of using parse_url.

$auth_endpoint .= (strpos($auth_endpoint, '?') === false ? '?' : '&') . http_build_query($auth_params, '', '&', $this->encType);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants