Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the User-Agent regardless of GET or POST #382

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Set the User-Agent regardless of GET or POST #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [unreleased]
* User-Agent is set for any HTTP method in fetchURL() (not just POST). #382
* Update visibility of getWellKnownConfigValue to protected. #363
* Fixed issue on authentication for php8. #354
* Support for signed and encrypted UserInfo response. #305
Expand Down
4 changes: 3 additions & 1 deletion src/OpenIDConnectClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,6 @@ protected function fetchURL(string $url, string $post_body = null, array $header
// Allows to keep the POST method even after redirect
curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'POST');
curl_setopt($ch, CURLOPT_POSTFIELDS, $post_body);
curl_setopt($ch, CURLOPT_USERAGENT, $this->getUserAgent());

// Default content type is form encoded
$content_type = 'application/x-www-form-urlencoded';
Expand All @@ -1381,6 +1380,9 @@ protected function fetchURL(string $url, string $post_body = null, array $header
$headers[] = "Content-Type: $content_type";
}

// Set the User-Agent
curl_setopt($ch, CURLOPT_USERAGENT, $this->getUserAgent());

// If we set some headers include them
if(count($headers) > 0) {
curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
Expand Down
Loading