Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defunct dfm call #242

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Fix defunct dfm call #242

merged 6 commits into from
Apr 10, 2024

Conversation

kbenoit
Copy link
Contributor

@kbenoit kbenoit commented Apr 1, 2024

Necessary to unblock CRAN from publishing quanteda v4

@juliasilge
Copy link
Owner

Thank you so much for this PR @kbenoit! 🙌

Do I understand correctly that you'd like me to do a tidytext release ASAP?

@@ -88,7 +88,8 @@ Note that a tidier is also available for the `dfm` class from the quanteda packa
library(methods)

data("data_corpus_inaugural", package = "quanteda")
d <- quanteda::dfm(data_corpus_inaugural, verbose = FALSE)
d <- quanteda::tokens(data_corpus_inaugural) %>%
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched to %>% because the package as a whole still does. I'll open an issue about that.

@kbenoit
Copy link
Contributor Author

kbenoit commented Apr 4, 2024 via email

@kbenoit
Copy link
Contributor Author

kbenoit commented Apr 4, 2024 via email

@juliasilge
Copy link
Owner

This is failing on R-devel because it can't build the brand new quanteda from source:

✖ Failed to build quanteda 4.0.0 (11.6s)

@kbenoit
Copy link
Contributor Author

kbenoit commented Apr 5, 2024

Yes we are actively trying to fix the r-devel (Fedora) platform build issues. It's tricky but hopefully, won't hold up your update.

@juliasilge
Copy link
Owner

Looks like waiting has only made the problem worse, actually. 😢 Now CI can't build quanteda on R-release either.

@kbenoit do you have any advice on how I can get quanteda up and running in CI? I did get an email from CRAN because of the quanteda release so now tidytext is on a deadline. I can pin an older version of quanteda in CI to get it to pass (right? the older version of quanteda will support the new change in the tidytext vignette?), but of course that defeats the purpose really.

@kbenoit
Copy link
Contributor Author

kbenoit commented Apr 8, 2024

Resubmitted quanteda today, I think we solved it now. New quanteda.textstats on CRAN, also seededlda and proxyC.
🤞

note to future self: Don't publish a major release right when the r-devel is also a major release!

@juliasilge
Copy link
Owner

Success now! 🚀 Thank you so much @kbenoit

@juliasilge juliasilge merged commit b61a650 into juliasilge:main Apr 10, 2024
8 checks passed
@kbenoit kbenoit deleted the quanteda-v4 branch April 10, 2024 10:55
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants