Added option to query User object for payload UID #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `useUserObject` option: allow User object to be queried for uid from payload.
julianlam
requested changes
Jun 14, 2019
There was a problem hiding this comment.
I can't approve this until the indentation issues are resolved. In particular. session-sharing.tpl's entire file is changed because your editor converted to spaces, I think. Let's keep it to tabs here.
Also can you elaborate on the use of this admin option? Thanks
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "nodebb-plugin-session-sharing", | |||
| "version": "4.5.0", | |||
| "version": "4.5.1", | |||
There was a problem hiding this comment.
Can you revert this line please?
| @@ -229,6 +229,9 @@ plugin.findOrCreateUser = function (userData, callback) { | |||
| } | |||
| queries.uid = async.apply(db.sortedSetScore, plugin.settings.name + ':uid', userData.id); | |||
|
|
|||
| if (plugin.settings.useUserObject === 'on') | |||
| queries.id = async.apply(db.getObjectField, 'user:' + userData.id, 'uid'); | |||
|
|
|||
There was a problem hiding this comment.
Indentation should be tabs for this plugin, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an admin option that if enabled will query the
Userobject for theidfound in the cookie payload if not first found in the usualbase appobject.