Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter the proxy settings being passed to curl #773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vorlonofportland
Copy link

env_proxy_settings() DTRT by default with no arguments. Passing 'https' as an argument just causes it to FAIL to honor no_proxy in the environment which it should.

env_proxy_settings() DTRT by default with no arguments.  Passing 'https' as
an argument just causes it to FAIL to honor no_proxy in the environment
which it should.
@ajkavanagh
Copy link
Contributor

@vorlonofportland please could you add a reason for why this PR is needed. e.g. is there a bug that it is fixing? Thanks.

@ajkavanagh ajkavanagh added the Incomplete For an issue, needs more information. For a PR, needs further work. label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incomplete For an issue, needs more information. For a PR, needs further work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants