Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Sort.getOrder and Sort.create #1124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lacinoire
Copy link

Thanks for contributing.

Description

Hey 😊
I want to contribute a test.
Curious to hear what you think!

(I wrote this test as part of a research study at TU Delft. Find out more)

Testing

Did you add a unit test?
Yes 😉

@Test
public void testGetOrderAndCreate0() throws Exception {
assertThrows(IllegalStateException.class, () -> {
Table table = Table.create("table1", IntColumn.create(" ales"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean for there to be a space in " ales"? if so, why?

@@ -149,4 +151,20 @@ public void createSortInvalidPrefixColumnDoesNotExist() {

assertEquals("Unrecognized Column: '>col2'", thrown.getMessage());
}

@Test
public void testGetOrderAndCreate0() throws Exception {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test name should be more descriptive. what behavior is being tested? i.e. why do you expect an IllegalStateException to be thrown?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants