Upgrade to ethers 6 #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradens
commented
Nov 27, 2023
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^14.11.2", | ||
| "ethereum-abi-types-generator": "^1.0.6", | ||
| "typescript": "^4.1.3" | ||
| "typescript": "^5.3.0" |
There was a problem hiding this comment.
I upgraded typescript since I was running into build errors after installing 6.6, and it was set to 4.1 which is quite old.
bradens
commented
Nov 27, 2023
| customProvider.nodeUrl | ||
| ); | ||
| } else { | ||
| ethersProvider = ethers.getDefaultProvider(); | ||
| ethersProvider = ethers.getDefaultProvider(1); |
There was a problem hiding this comment.
Previously ethers would default to ethereum mainnet, so just maintaining parity here
joshstevens19
requested changes
Nov 27, 2023
There was a problem hiding this comment.
good PR thanks a lot but we need to keep support for ethers v5 as well you can work out if its v6 or v5 in the code itself when they pass in the provider using the missing objects or defined objects of the provider passed in; we should basically do it similar on how we split web3 and ethers and take it down the correct route so if you try to make it follow how it does web3 and ethers routes then it would be great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an upgrade to ethers 6.
Mostly following the migration guide here: https://docs.ethers.org/v6/migrating/
It's a pretty big change API wise. I'm not sure if the intention was to maintain support for both 5.x and 6.x at the same time.
The biggest change here is that ethers 6 has
biginttypes instead of theirBigNumberinstance, which causes headaches when trying to serialize. It was causing silent failures during thedeepClonefunction, so I opted to use a bigint safe clone instructuredClone, which is included in nodejs 17+, and almost all browsers.https://nodejs.org/en/about/previous-releases
If we need to, there are
structuredClonepolyfills that could be added.