Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show categories with cookies attached and don't load cookie manager when no cookies are defined #30

Conversation

shazmasiddiqui
Copy link
Contributor

Partial pull Request for Issue #14

Summary of Changes

  • Cookie manager will not load in frontend if there are no cookies defined
  • Consent banner modal in the frontend will only show the categories which have cookies attached

Testing Instructions

  • Don't create any cookies and check in the frontend the cookie manager settings button shouldn't be visible
  • Create cookies and add them to any category, these categories should be visible in consent banner model in the frontend
  • Create categories but don't add any cookies to them, these categories should not be shown in consent banner model in the frontend

Actual result BEFORE applying this Pull Request

  • Cookie manager settings button is shown in the frontend even if there are no cookies defined
  • Categories which don't have any cookies attached to them are also shown in the consent banner model

Expected result AFTER applying this Pull Request

  • Cookie manager settings button is only visible when at least one cookie is defined
  • Only categories which have at least one cookie attached to them are shown in the consent banner model

@roland-d
Copy link
Collaborator

roland-d commented Jun 3, 2022

@shazmasiddiqui There is one issue with your PR. The frontend shows the category ID instead of the category name:
image

@rjharishabh
Copy link
Collaborator

Issue #15

@fancyFranci fancyFranci merged commit 64df7ee into joomla-projects:final-cookie-manager Jan 8, 2023
@fancyFranci
Copy link
Collaborator

I wasn't able to reproduce the issue, so I merged it. When it is still there, we will fix it in another PR. Thanks for all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants