Main PR

[bembelimen]

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

[brianteeman]

Where am I supposed to input the new key?

[brianteeman]

should not be possible to save a single modifier key

[brianteeman]

just thinking that there is another possible approach that could be used.

the main reason for making the keys editable is because of potential conflicts. if we remove the need for them to be editable then a lot of the highlighted issues could be solved.

a way to do this would be to use a unique modifier key. this is what github does - they use the g as the modifier. we could do the same using a j

maybe this would simplify things and enable the code to be mergable.

would still need a quick way for a user to discover the keys

[brianteeman]

With the latest changes to remove shortcut editing there is no need to use an external additional script. The code can be just added to toolbar.js as suggested here joomla/joomla-cms#24152 (comment). Other than the popup we're basically at the same code as proposed three years ago.

Plus there are several obvious bugs.

As my help here is not appreciated I will refrain from commenting further

[fancyFranci]

I really don't know why you have the idea your help is not appreciated. I did what you said, because your comments have a point. Now it's the wrong place, but nothing easier than moving code. I just need to know about it as I'm not reading 3 year old comments :D When the editing feature had more time and works better we can move to a plugin again.

[brianteeman]

I really don't know why you have the idea your help is not appreciated.

well at no point have you acknowledged that you have made any changes - if I wasn't looking at the commits I wouldnt have known.

'm not reading 3 year old comments

"Those that do not learn from history are doomed to repeat it"

[chmst]

Three years ago, Francisca did not know what joomla is :)
Will try to contribute here - as it is a really useful feature and I would like to have it in 4.2

[fancyFranci]

Now I read through the PR with the toolbar comment, but the plugin here is providing a possibility for extensions to add their shortcuts to joomla too. So the new shortcut plugin offers more than a keydown event handler script.
About answering your comments - you reacted much faster to my commits than I would be able to write proper english. But I understand you and try to make it better in the future :)
I was there 3 years ago, but Joomla has too much history to know it all :P

[brianteeman]

I probably commented too strongly out of frustration at wasting time with the cookie manager.

providing a possibility for extensions to add their shortcuts to joomla too.

Could you explain how please.

[brianteeman]

@chmst do you thik thaat the lists in the overview should be DL instead of the current UL

[chmst]

@brianteeman yes, DL is better, i wanted to write that already. Sorry that I did not jump in earlier.

And I have a few other ideas what we can improve.

But the most important is imho to get the plugin into the core - as Draft - but then it is easier to test.

[chmst]

The Information now is a small text area.
For a quick improvment we can maybe use a <div class="alert alert-info"> for that.
Otherwise it is an a11y issue - the information icon needs the attribute aria-hidden="true".

For future improvment we could have an icon (fa-fas keyboard) like the accessibility icon.

[fancyFranci]

I changed the ul to dl (which I didn't used before, so please check if its correct) and the keyboard icon fits. Later I will try to make a button in the corner instead of this info text and create the official PR. It will have more documentation and description, e.g. how another extension could add shortcuts :) Thanks to you two for all the feedback!

[chmst]

@fancyFranci thank you - will test asap!

[fancyFranci]

You can find the joomla-cms PR here now joomla/joomla-cms#38092. I'm happy when it can be in 4.2 because it is so nice to use the shortcuts, but as time is running... we will see. Thanks everyone! :)