Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fullscreen bypass support #808

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aedalzotto
Copy link

@aedalzotto aedalzotto commented Mar 3, 2021

This pull request adds support for automatically disabling redshift when a fullscreen application is detected, solving issue #548.
There is a possibility to disable this function from command line with the option "-f 0".

Differing from #407, this implements the function in the redshift daemon.
It does not use the EWMH because it is not reliable enough (confirmed poor compatibility with i3).
No implementation has been made for Windows yet, but the code should still compile.


EDIT:
Also, there is a SIGUSR2 and a checkbox in redshift-gtk to disable this function at any time.


EDIT:
Multi-monitor support is a bit tricky and must be decided how it should work before it is developed.
I think it must check if the focused window is fullscreen in its display and disable redshift for all displays, or make a per-display control, but I don't know if this is possible.

@@ -50,10 +51,18 @@ sigdisable(int signo)
disable = 1;
}

/* Signal handler for disabling the fullscreen detector signal */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redshift is in sore need of a control interface other than signals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants