Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix presentation issue #702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix presentation issue #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Pod/Classes/SideMenuAnimationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ private extension SideMenuAnimationController {
else { return }

originalSuperview = presentingViewController.view.superview
containerView?.addSubview(presentingViewController.view)
containerView?.addSubview(presentedViewController.view)
}

Expand Down
3 changes: 1 addition & 2 deletions Pod/Classes/SideMenuPresentationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ internal final class SideMenuPresentationController {
guard config.statusBarEndAlpha > .leastNonzeroMagnitude else { return nil }

return UIView {
$0.backgroundColor = config.presentationStyle.backgroundColor
$0.backgroundColor = .clear
$0.autoresizingMask = [.flexibleHeight, .flexibleWidth]
$0.isUserInteractionEnabled = false
}
Expand Down Expand Up @@ -104,7 +104,6 @@ internal final class SideMenuPresentationController {
}

presentingViewController.view.isUserInteractionEnabled = config.presentingViewControllerUserInteractionEnabled
containerView.backgroundColor = config.presentationStyle.backgroundColor

layerViews()

Expand Down
2 changes: 0 additions & 2 deletions Pod/Classes/SideMenuPresentationStyle.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import UIKit

@objcMembers
open class SideMenuPresentationStyle: InitializableClass {
/// Background color behind the views and status bar color
open var backgroundColor: UIColor = .black
/// The starting alpha value of the menu before it appears
open var menuStartAlpha: CGFloat = 1
/// Whether or not the menu is on top. If false, the presenting view is on top. Shadows are applied to the view on top.
Expand Down