Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip: Update 'About' section #1057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/assets/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@
<title>About RunnerUp</title>
</head>
<body>
<h2>Privacy</h2>
<p>RunnerUp records location (GPS) when an activity is started, as well steps (for cadence), temperature & pressure from internal sensors, if activated.
<br>The recording is done also when the app is in background (a notification is always shown when location is enabled)
<br>A user can export this information to accounts (files or web services), the information is not shared in any other way.
</p>
<p>The external accounts have separate privacy policies.</p>
<p><b>Note:</b> MapBox enables tracking by default (when using the map to view activities).
<br>This can be disabled (opt-out) from the MapBox logo's info button on the lower left corner when viewing the map.
</p>
<p>The usage of the map has a separate policy: <a href="https://www.mapbox.com/legal/privacy">MapBox privacy policy</a></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The privacy policy in itself should be updated with telemetry etc (maybe cut from here).
The "always using location" notification should be explained too.

Thoughts: All in the app is translated but not this. Probably OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For to translate, it doesn't work with strings.xml, I guess!?
Adding language specific html isn't an option, is it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Transifex could handle this by adding file types, have not investigated.
But that is separate, not part of the PR

Similar with replacing MapBox

<h2>RunnerUp</h2>
<p><a href="https://github.com/jonasoreland/runnerup/wiki">RunnerUp wiki</a></p>
<p><a href="https://github.com/jonasoreland/runnerup/issues">RunnerUp issue list</a></p>
Expand Down