Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update torchaudio resampling #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carolineechen
Copy link

Resolves #6

Summary of Changes

  • used the latest version of torchaudio (0.9.0), which contains various resampling improvements
  • replaced torchaudio resample_waveform with the new functional.resample, since compliance.kaldi.resample is being deprecated
  • removed functional.resample from impulse graphs and replaced functional.resample spectrograms with transforms.Resample using a larger lowpass_filter_width parameter, similar the julius plots. functional.resample should numerically match transforms.Resample, so plotting both seems redundant
  • updated README to reflect resampling times in notebook as run on my local machine

Let me know if you have any questions or suggestions!

@jonashaag
Copy link
Owner

Huh, I did a review very soon after you created this PR. Where has it gone?! Will have to do it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torchaudio resampling bug in notebook and updates
2 participants