Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --since to wait_for_docker_container_task example #500

Conversation

YannCharlou-CleverAge
Copy link
Contributor

@YannCharlou-CleverAge YannCharlou-CleverAge commented Jul 31, 2024

to avoid checking the logs from a previous container start

Fix my previous PR #498 to use a real RFC3339 date for the --since docker command option

examples/wait_for.php Outdated Show resolved Hide resolved
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pyrech
Copy link
Member

pyrech commented Aug 1, 2024

@YannCharlou-CleverAge Could you rebase your PR on top of branch main and fix the CS so we can merge it?

@YannCharlou-CleverAge YannCharlou-CleverAge force-pushed the example-wait_for_docker_container-since-0 branch from 061a4e4 to de970b5 Compare August 4, 2024 16:22
@YannCharlou-CleverAge
Copy link
Contributor Author

@YannCharlou-CleverAge Could you rebase your PR on top of branch main and fix the CS so we can merge it?

Sorry for the delay I was very busy these days.

  • coding standards : fixed
  • branch : rebased

Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lyrixx lyrixx merged commit 535a420 into jolicode:main Aug 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants