Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework player progress reporting #477

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Rework player progress reporting #477

merged 6 commits into from
Aug 14, 2023

Commits on Aug 1, 2023

  1. ♻️ Simplify generatePlaybackProgressInfo

    @Maxr1998
    Maxr1998 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    87e1eec View commit details
    Browse the repository at this point in the history

  2. ♻️ Rewrite playback state reporting

    @Maxr1998
    Maxr1998 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3d72f67 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. 🐛 Don't report previously stopped tracks again

    @Maxr1998
    Maxr1998 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6812d0f View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Resolve TODO

    @Maxr1998
    Maxr1998 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f240762 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. 🐛 Remove the playback state age check again for now 

    The playbackEventStream unfortunately isn't frequent enough, causing the previous event to sometimes be older than the specified maximum age.
This causes stop events to be dropped sometimes.
Thus, we revert this, but also ensure that the position, that is automatically extrapolated based on the current time, doesn't exceed the duration of the track.
    @Maxr1998
    Maxr1998 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    063a50a View commit details
    Browse the repository at this point in the history

  2. Don't send stop events for paused tracks at position 0

    @Maxr1998
    Maxr1998 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0a054e0 View commit details
    Browse the repository at this point in the history