add missing tooltips button, remove phantom buttons

jmshrv · Sep 24, 2024 · 62ee5ee · 62ee5ee
1 parent fa4a500
commit 62ee5ee
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 50 deletions.
diff --git a/lib/components/AlbumScreen/download_button.dart b/lib/components/AlbumScreen/download_button.dart
@@ -85,57 +85,45 @@ class DownloadButton extends ConsumerWidget {
         tooltip: parentTooltip,
       ),
     );
-    var deleteButton = Semantics.fromProperties(
-      properties: SemanticsProperties(
-        label: AppLocalizations.of(context)!.deleteItem,
-        button: true,
-      ),
-      container: true,
-      child: IconButton(
-        icon: const Icon(Icons.delete),
-        // If offline, we don't allow the user to delete items.
-        // If we did, we'd have to implement listeners for MusicScreenTabView so that the user can't delete a parent, go back, and select the same parent.
-        // If they did, AlbumScreen would show an error since the item no longer exists.
-        // Also, the user could delete the parent and immediately redownload it, which will either cause unwanted network usage or cause more errors because the user is offline.
-        onPressed: () {
-          showDialog(
-            context: context,
-            builder: (context) => ConfirmationPromptDialog(
-              promptText: AppLocalizations.of(context)!.deleteDownloadsPrompt(
-                  item.baseItem?.name ?? "", item.baseItemType.name),
-              confirmButtonText:
-                  AppLocalizations.of(context)!.deleteDownloadsConfirmButtonText,
-              abortButtonText:
-                  AppLocalizations.of(context)!.deleteDownloadsAbortButtonText,
-              onConfirmed: () async {
-                try {
-                  await downloadsService.deleteDownload(stub: item);
-                  GlobalSnackbar.message((scaffold) =>
-                      AppLocalizations.of(scaffold)!.downloadsDeleted);
-                } catch (error) {
-                  GlobalSnackbar.error(error);
-                }
-              },
-              onAborted: () {},
-            ),
-          );
-          // .whenComplete(() => checkIfDownloaded());
-        },
-      )
+    var deleteButton = IconButton(
+      icon: const Icon(Icons.delete),
+      tooltip: AppLocalizations.of(context)!.deleteItem,
+      // If offline, we don't allow the user to delete items.
+      // If we did, we'd have to implement listeners for MusicScreenTabView so that the user can't delete a parent, go back, and select the same parent.
+      // If they did, AlbumScreen would show an error since the item no longer exists.
+      // Also, the user could delete the parent and immediately redownload it, which will either cause unwanted network usage or cause more errors because the user is offline.
+      onPressed: () {
+        showDialog(
+          context: context,
+          builder: (context) => ConfirmationPromptDialog(
+            promptText: AppLocalizations.of(context)!.deleteDownloadsPrompt(
+                item.baseItem?.name ?? "", item.baseItemType.name),
+            confirmButtonText:
+                AppLocalizations.of(context)!.deleteDownloadsConfirmButtonText,
+            abortButtonText:
+                AppLocalizations.of(context)!.deleteDownloadsAbortButtonText,
+            onConfirmed: () async {
+              try {
+                await downloadsService.deleteDownload(stub: item);
+                GlobalSnackbar.message((scaffold) =>
+                    AppLocalizations.of(scaffold)!.downloadsDeleted);
+              } catch (error) {
+                GlobalSnackbar.error(error);
+              }
+            },
+            onAborted: () {},
+          ),
+        );
+        // .whenComplete(() => checkIfDownloaded());
+      },
     );
-    var syncButton = Semantics.fromProperties(
-      properties: SemanticsProperties(
-        label: AppLocalizations.of(context)!.syncDownloads,
-        button: true,
-      ),
-      container: true,
-      child: IconButton(
-        icon: const Icon(Icons.sync),
-        onPressed: () {
-          downloadsService.resync(item, viewId);
-        },
-        color: status.outdated ? Colors.orange : null,
-      )
+    var syncButton = IconButton(
+      icon: const Icon(Icons.sync),
+      tooltip: AppLocalizations.of(context)!.syncDownloads,
+      onPressed: () {
+        downloadsService.resync(item, viewId);
+      },
+      color: status.outdated ? Colors.orange : null,
     );
     if (isOffline) {
       if (status.isRequired) {

diff --git a/lib/components/now_playing_bar.dart b/lib/components/now_playing_bar.dart
@@ -247,6 +247,7 @@ class NowPlayingBar extends ConsumerWidget {
                                           color: Color.fromRGBO(0, 0, 0, 0.3),
                                         ),
                                         child: IconButton(
+                                          tooltip: "Toggle Playback",
                                           onPressed: () {
                                             FeedbackHelper.feedback(
                                                 FeedbackType.light);