Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

Use sameAs function in confirm password #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yacosta738
Copy link
Contributor

  • Please make sure the below checklist is followed for Pull Requests.

  • [x ] All continuous integration tests are green

  • [ x] Tests are added where necessary

  • [ x] Documentation is added/updated where necessary

  • [ x] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

changes in validations (Vuelidate): check if the passwords match in the views "change-password" and "reset-password-finish". With the use of the sameAs function it is not necessary to check the password length. The same can be applied in the registry but I leave that to you

@pascalgrimaud
Copy link
Member

pascalgrimaud commented Jul 16, 2020

Thanks for your contribution here @yuniel-acosta
But maybe you don't know, Vue has been integrated directly to main generator-jhipster so I think it's better to propose your change directly there, instead of this repo

Can you open the same PR there, plz ?

@yacosta738
Copy link
Contributor Author

ok i will update the repo generator-jhipster and make the relevant changes. My question is, is this repository going to be obsolete

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants