Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdminUserDTO and the PublicUserResource #216

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

gzsombor
Copy link
Member

To separate the publicly accessible user information from the private one.
Porting jhipster/generator-jhipster#12374

@JasonTypesCodes
Copy link
Contributor

Thanks @gzsombor ! It looks like the gradle-jwt-react sample end to end UI tests need to be checked with these updates.

Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @gzsombor for contributing this. @JasonTypesCodes We should now decide when to do the last/final release based on 6.x as this feature is already part of 7.x if I am not mistaken (and we will not backport it).

@gzsombor
Copy link
Member Author

gzsombor commented Jan 1, 2021

I think the problem is that this blueprint still use the old - 6.x templates - for the frontend generation.
I tried to migrate this blueprint to the latest generator, but I didn't have success.

@JasonTypesCodes
Copy link
Contributor

Looks good to me. Thanks @gzsombor for contributing this. @JasonTypesCodes We should now decide when to do the last/final release based on 6.x as this feature is already part of 7.x if I am not mistaken (and we will not backport it).

I picked up the 1.0 conversation in its issue (#189)

@atomfrede atomfrede added the main:v7 requires main generator v7 label Jan 18, 2021
@mraible
Copy link
Contributor

mraible commented Aug 8, 2022

@gzsombor This project has been updated to use JHipster 7 in #265. Does that make it so you can fix and commit this?

@gzsombor
Copy link
Member Author

gzsombor commented Aug 9, 2022

Sure, I will try to rebase my patch

@gzsombor gzsombor force-pushed the implement-12374 branch 2 times, most recently from b20cd2f to 7a4582c Compare August 10, 2022 07:04
@mraible
Copy link
Contributor

mraible commented Aug 16, 2023

@gzsombor Can you please resolve conflicts or close?

@gzsombor
Copy link
Member Author

I've rebased the code, but I can't test it locally, using 'mhipster' or calling 'jhipster --blueprints micronaut' or 'npx jhipster --blueprints micronaut' ends up with this error:

CommonJS modules can always be imported via the default export, for example using:

import pkg from '../../../jdl/jhipster/reserved-keywords.js';
const { isReservedTableName } = pkg;

file:///mnt/butterfs/projects/jhipster/generator-jhipster/dist/generators/server/support/prepare-entity.mjs:21
import { isReservedTableName } from '../../../jdl/jhipster/reserved-keywords.js';
         ^^^^^^^^^^^^^^^^^^^
SyntaxError: Named export 'isReservedTableName' not found. The requested module '../../../jdl/jhipster/reserved-keywords.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '../../../jdl/jhipster/reserved-keywords.js';
const { isReservedTableName } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

The developer setup is not documented at all, and I can't google it, how to solve. Any recommendation which works with the current JHipster generator?

@mraible
Copy link
Contributor

mraible commented Aug 17, 2023

@gzsombor I just merged the upgrade to JHipster 7.9.3, so you might try rebasing again. I created an app last night with the following command after running npm link:

mhipster jdl ~/dev/generator-jhipster-micronaut/test-integration/samples/gradle-oauth-angular.jdl \
  --skip-jhipster-dependencies --force

@gzsombor
Copy link
Member Author

Thanks, it turned out, if I don't want to use the development jhipster-generator, it works properly :)

I've rebased, and fixed a couple of smaller issues around the DTO naming, I'm hopeful, that the tests will be green

@mraible
Copy link
Contributor

mraible commented Aug 17, 2023

@gzsombor It looks like you need to run npm run update-snapshot.

@gzsombor
Copy link
Member Author

thanks, I've rebased the change, and fixed the silly search&replace typo bug... This will work now :)

@gzsombor
Copy link
Member Author

And everything is green now, we can merge it :)

@mraible mraible merged commit aeae9eb into jhipster:main Aug 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main:v7 requires main generator v7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants