changed transmission ratio calculation to total size instead of downloaded size #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
reviewed
Aug 20, 2024
| @@ -383,7 +383,7 @@ class TransmissionClientGatewayService extends ClientGatewayService { | |||
| ...(await Promise.all( | |||
| torrents.map(async (torrent) => { | |||
| const percentComplete = (torrent.haveValid / torrent.totalSize) * 100; | |||
| const ratio = torrent.downloadedEver === 0 ? -1 : torrent.uploadedEver / torrent.downloadedEver; | |||
| const ratio = torrent.totalSize === 0 ? -1 : torrent.uploadedEver / torrent.totalSize; | |||
There was a problem hiding this comment.
how could torrent.totalSize === 0 ?
There was a problem hiding this comment.
It's should not happen, but if it does might as well handle it.
There was a problem hiding this comment.
Don't think this will happen. also it's wrong. we should use totalSize based ratio only when torrent is not downloaded at all, which means torrent.downloadedEver === 0, not torrent.totalSize === 0
There was a problem hiding this comment.
I see so something like this ?
const ratio = torrent.downloadedEver === 0 ? torrent.uploadedEver / torrent.totalSize : torrent.uploadedEver / torrent.downloadedEver;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transmission ratio calculation was based on
torrent.uploadedEver/torrent.downloadedEver, which caused some torrents not initiated in flood to have a ratio of -1.Description
The calculation is now based on
torrent.uploadedEver / torrent.totalSizeRelated Issue
#720
Screenshots
Before change:
Note the ratio is -1
After change
Note the ratio is now correctly displayed: 0.01