Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spare Instance parameter to consider idle executors #430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Graham42
Copy link

If we're using more than 1 executor per agent and the scheduling
strategy spreads builds across the existing agents, we could end up
scaling up many more agents than we need.

If we're using more than 1 executor per agent and the scheduling
strategy spreads builds across the existing agents, we could end up
scaling up many more agents than we need.
@res0nance
Copy link
Contributor

Could you add a test for this?

@res0nance res0nance added the enhancement Feature additions or enhancements label Feb 27, 2020
@Graham42
Copy link
Author

I don't see any existing tests for this area of the code (unless I've missed something) and I'm not invested enough in this change right now to write a new test suite from scratch. If someone else wants to take on tests for this feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature additions or enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants