-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ES modules for gatsby config #1429
Conversation
this is so cool. I wasn't aware we upgraded gatsby enough to support this. |
5f66733
to
0e7d438
Compare
@halkeye there are still some files that we might be able to rename, but when I tried that with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks so much!
@@ -64,6 +64,7 @@ pipeline { | |||
stage('Lint and Test') { | |||
environment { | |||
NODE_ENV = "development" | |||
NODE_OPTIONS="--experimental-vm-modules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this for 18? 18 should have full module support
if not, do you want to goto 20 instead? I don't really like using the flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only used during lint+test stage. I think it's more related to Jest implementation than Node version, see https://jestjs.io/docs/ecmascript-modules
can you tell me how to generate that output? |
@halkeye see https://github.com/jenkins-infra/plugin-site/pull/1429/checks?check_run_id=14690302296 -- caused by reverting Eslint config in 618e48d |
I'm pretty checked out. If you think its a win, go ahead and merge it. I'm still a little uncomfortable with --experimental-vm-modules but I know how messy jest can get. |
This should unlock some dependency updates