Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nginx-website): add overrideLocations option #1346

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

smerle33
Copy link
Contributor

@smerle33 smerle33 commented Sep 18, 2024

as per jenkins-infra/helpdesk#4132 (comment) and jenkins-infra/helpdesk#4291

allow to provide a overrideLocations key to custom the locations within the nginx configuration file.

@smerle33 smerle33 marked this pull request as draft September 18, 2024 15:44
@smerle33 smerle33 marked this pull request as ready for review September 18, 2024 15:54
@dduportal dduportal added enhancement New feature or request nginx-website labels Sep 18, 2024
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Blocking suggestion (version bump is incorrect)
  • (nit) Could you update the PR description to explain the PR? You wrote about the context, but what this PR does?

charts/nginx-website/Chart.yaml Outdated Show resolved Hide resolved
@dduportal dduportal merged commit 70cf1b7 into jenkins-infra:main Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nginx-website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants