Fix incorrect data type being passed to OverviewDialog.Overview
#1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimdogx
approved these changes
Sep 28, 2024
|
Let me see if I can reproduce. If so, we should rebase this on the |
|
Music library -> select artist -> hit * to make description full screen I wasn't able to make prod crash using full screen dialog on the artist overview page so this should be fine in master. Thanks for the PR! |
cewert
approved these changes
Sep 28, 2024
cewert
added
the
code-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix a few type mismatch errors when setting the
Overviewfield onOverviewDialog. (discovered while testing the v1 brighterscript alphas)I'm not sure how to trigger each of these functions, but it appears to be a clear issue of passing the wrong data type so should be pretty straightforward?
Issues