Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current macOS build enabled glib integration for harfbuzz which is not enabled anywhere else. Disable that to reduce dependency maintenance work and to match other platforms.
Current Xcode no longer need the
ld-classic
to statically link ffmpeg. Commented out that workarondPrefer macOS native vDSP instead of fftw as the fft library, which is faster especially on Apple Silicon:
Theoretical benchmark:
Actual perf in ffmpeg chromaprint:
Tested with
ffmpeg -f lavfi -i "sine=frequency=1000:duration=7200" -f chromaprint -fp_format raw /dev/null -benchmark
current fftw3f:
vDSP:
Changes
Issues