Implement My media (small) home section #4011
Conversation
|
Note that this still displays different from jellyfin-web. It's really just the same card but smaller, instead of those awful buttons in a grid. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Set size | ||
| if (small) { | ||
| cardView.setMainImageDimensions(133, 75) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
|
|
||
| // Set size | ||
| if (small) { | ||
| cardView.setMainImageDimensions(133, 75) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| if (small) { | ||
| cardView.setMainImageDimensions(133, 75) | ||
| } else { | ||
| cardView.setMainImageDimensions(224, 126) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| if (small) { | ||
| cardView.setMainImageDimensions(133, 75) | ||
| } else { | ||
| cardView.setMainImageDimensions(224, 126) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
Changes
Screenshots
Comparison with previous size (first row)
Issues
Fixes #1499
Fixes #2093
Fixes #2721
Fixes #3176
Fixes #3664
Fixes #3749