Remove Generic Handler Support / Implementation (Leaving Failing Tests) #1068
+379
−443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into multiple registration extension.
- leaving tests for future implementation behavior.
|
Oh I can't merge this without replacing the new behavior, I was going to use this as a starting point for refactoring. |
|
Yeah I think you could just use the opt-in version as a starting point for the refactoring in my opinion. Or we can rename this PR in some sort of way to let people try and get the tests passing with an implementation that satisfies your requirements. Idk.. lol |
…ultiple-addition-extension Open behavior multiple registration extensions
Remove duplicate `Nullable` property from `MediatR.Contracts`
…upport Timeout behavior support
jbogard
merged commit cf5bdf5
into
jbogard:dynamic-generic-stuffing
3 of 4 checks passed
|
Well I don't think I can do this with the stock container. Lamar has support for this kind of thing but it replaces the stock container to do its thing. I'll just keep this existing behavior, even if I don't super like it lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Generic Handler Support / Implementation and leaves the failing tests for future development / support behaviors as requested from @jbogard
I can't say that I agree with this approach. I feel like it would be better to leave the current implementation in while a better implementation is developed. It doesn't really make sense to add the feature then remove it just to re-add it again in the future when someone can develop it in the way you are wanting. I feel like it's better to just leave the working implementation in the opt in paradigm (opt in feature flag sort of behavior) and let people try to develop in a better way while the current feature is working. That is more of a "Red, Green, Refactor" approach. It doesn't really make sense to me to remove a feature that :
Those are my thoughts and opinions on it. However, this isn't my choice to make and that is fine.
Cheers.