Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for everyone option to is_active_for_user #491

Merged

Conversation

jdoconnor
Copy link
Contributor

fixes #401

This adds support of the everyone boolean to is_active_for_user

@clintonb clintonb merged commit 21d7fad into jazzband:master Nov 24, 2023
8 checks passed
@jwhitlock
Copy link

Should this also return False if everyone is False, and only continue on a per-user check if everyone is None? This is how flag.is_active works:

https://github.com/django-waffle/django-waffle/blob/63444d6f83a3c75a9630a02e32cfe65ac1305b86/waffle/models.py#L282-L285

@chess-octane
Copy link

I agree with @jwhitlock . I wonder what are your thoughts @clintonb ?

@chess-octane
Copy link

I submitted a PR to tackle that: #498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_active_for_user() doesn't respect flag.everyone
4 participants