Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use TotalXXX instead of NumXXX #381

Merged
merged 1 commit into from
Sep 25, 2024
Merged

use TotalXXX instead of NumXXX #381

merged 1 commit into from
Sep 25, 2024
+67 −30

Commits on Sep 23, 2024

  1. use TotalXXX instead of NumXXX 

    All other fields that contain a total amount of something begin with the
word `Total` except for the `pkg/cpu.Processor.NumCores` and
`NumThreads` fields. This commit adds new fields to `pkg/cpu.Processor`
called `TotalCores` and `TotalHardwareThreads` to bring the names of
these fields in-line with all other amount/total fields.

In addition, adds a `TotalHardwareThreads` field to the `pkg/cpu.Info`
struct and deprecates the less-explicit `TotalThreads` field.

I'd like to remove the now-deprecated `NumThreads`, `NumCores`, and
`TotalThreads` fields before we get to a `v.1.0` series.

Signed-off-by: Jay Pipes <[email protected]>
    @jaypipes
    jaypipes committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    464a1c2 View commit details
    Browse the repository at this point in the history