Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: returning binding from awaited fn calling .then #35

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

james-elicx
Copy link
Owner

This PR does the following:

  • Fixes an issue where returning binding(...) from an async function would attempt to call .then on binding(...), leading to an error getting thrown.

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

🦋 Changeset detected

Latest commit: f6fad9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cf-bindings-proxy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

🧪 A prerelease is available for testing 🧪

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.ixion-labs.workers.dev/james-elicx/cf-bindings-proxy/runs/6040110466/npm-package-cf-bindings-proxy-35

Or you can immediately run this with npx:

npx https://prerelease-registry.ixion-labs.workers.dev/james-elicx/cf-bindings-proxy/runs/6040110466/npm-package-cf-bindings-proxy-35

@james-elicx james-elicx merged commit ab73898 into main Aug 31, 2023
5 checks passed
@james-elicx james-elicx deleted the james/fix-awaited-return branch August 31, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant