Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bugfix actions. #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

olivermue
Copy link

@olivermue olivermue commented Nov 7, 2018

A bugfix behaves the same as a feature (despite the prefix). So simply the feature stuff was copied and adopted to bugfix.


This change is Reviewable

@jakobehn
Copy link
Owner

Thanks for the PR!

For some reason the extension hangs when I click on the GitFlow icon in Team Explorer. It's consistent, I've rebuilt the branch from scratch.

Any idea what could cause this? Which version of VS have you been using when developing and testing this?

@olivermue
Copy link
Author

Okay, you got me.

I couldn't test it on my machine, cause a bunch of dependency DLLs are missing (especially Microsoft.TeamFoundation.Controls, Microsoft.TeamFoundation.Client, Microsoft.TeamFoundation.Git.Provider). Due to the fact that I have VS 2017 installed only they are not available. I just wrote the code and hoped for the best.

So if it doesn't work, give me a week or two (currently I have a bunch of other tasks on my desk). I'll install VS 2015 and try to find the reason.

@jakobehn
Copy link
Owner

No worries! :-)

I might look into it a bit more, I couldn't spot anything that was wrong when I looked through the changes.

Btw, you shouldn't have to have VS2015 installed, as long as you build the correct configuration (there is one for each version of VS, that brings in the corresponding references)

@olivermue
Copy link
Author

The problem is, that I have installed VS 2017 (15.x) only. This also uses the folder
C:\Program Files (x86)\Microsoft Visual Studio 14.0,
but the subfolder
Common7\IDE\CommonExtensions\Microsoft\TeamFoundation
is missing. So by using the Debug or Release configuration (cause VS2013 and VS2015 doesn't match) it tries to find Microsoft.TeamFoundation.Client.dll, Microsoft.TeamFoundation.Controls.dll and Microsoft.TeamFoundation.Git.Provider.dll which don't exist on my machine. I already checked my installed features with the installer, but I can't see anything that is not already enabled.

@jakobehn jakobehn mentioned this pull request Nov 26, 2018
@cremor
Copy link

cremor commented Jan 31, 2019

I'm looking forward to this feature. Any news on when it might be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants