Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error when playing #1632

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix error when playing #1632

merged 2 commits into from
Aug 1, 2024

Conversation

kokofixcomputers
Copy link
Contributor

This pull request...

  • Fixes a bug
  • Introduces a new feature
  • Improves an existing feature
  • Boosts code quality or performance

Description

Fixes cannot play

Relevant Issue(s)

This PR closes issue #...

@kokofixcomputers
Copy link
Contributor Author

An error message [19:32:35] [ERROR] [SignatureCipherManager]: Problematic YouTube player script /s/player/20dfca59/player_ias.vflset/en_US/base.js detected (issue detected with script: no n function match). Dumped to /tmp/lavaplayer-yt-player-script15744017416429671084.js may still be thrown, but it doesn't affect the functionality unlike before

@MichailiK MichailiK self-requested a review July 31, 2024 20:22
Copy link
Collaborator

@MichailiK MichailiK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should look good, albeit I haven't tested this yet. I'd expect for this to get merged soon & a new release being made later as well.

@jagrosh jagrosh merged commit e6bfd18 into jagrosh:master Aug 1, 2024
2 checks passed
@kokofixcomputers
Copy link
Contributor Author

Should look good, albeit I haven't tested this yet. I'd expect for this to get merged soon & a new release being made later as well.

@MichailiK Thanks! I have tested this myself and it works pretty well

lilliepad1 added a commit to lilliepad1/MusicBotShiverFork that referenced this pull request Aug 10, 2024
ElerWohlmuthFH pushed a commit to ElerWohlmuthFH/MusicBot that referenced this pull request Sep 20, 2024
* fix error when playing

* Update youtube source to 1.5.1

---------

Co-authored-by: Michaili K <[email protected]>
MichailiK added a commit to MichailiK/MusicBot that referenced this pull request Sep 25, 2024
* fix error when playing

* Update youtube source to 1.5.1

---------

Co-authored-by: Michaili K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants