Skip to content

Commit

Permalink
Feat: add depcheck 1.4.7 in package.json (#2202)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Resolves #2132

## Description of the changes
- Add `depcheck 1.4.7` in `package.json`
- Remove add global `depcheck` in CI test

## How was this change tested?
- manual test

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: tico88612 <[email protected]>
  • Loading branch information
tico88612 authored Mar 9, 2024
1 parent 8fe552a commit d47648a
Show file tree
Hide file tree
Showing 4 changed files with 313 additions and 10 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/lint-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ jobs:
node-version: '18'
- run: yarn install --frozen-lockfile
- name: Run depcheck
run: |
yarn global add depcheck
yarn run depcheck
run: yarn run depcheck
- run: yarn lint
- run: yarn build
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"@babel/eslint-parser": "^7.23.10",
"@typescript-eslint/eslint-plugin": "7.1.0",
"@typescript-eslint/parser": "7.1.0",
"depcheck": "1.4.7",
"eslint": "8.57.0",
"eslint-config-airbnb": "19.0.4",
"eslint-config-prettier": "9.1.0",
Expand Down
2 changes: 1 addition & 1 deletion scripts/run-depcheck.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ runDepcheck() {
local dir="$1"
local cfg="$2"
echo "Checking ${dir}"
depcheck "${dir}" --config "${cfg}" | sed 's/^\*/⛔/' | sed 's/^/ /g'
node node_modules/depcheck/bin/depcheck.js "${dir}" --config "${cfg}" | sed 's/^\*/⛔/' | sed 's/^/ /g'
return $((! ${PIPESTATUS[0]}))
}

Expand Down
Loading

0 comments on commit d47648a

Please sign in to comment.