Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go type mapping for new timestamp fields from #95 #98

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Add Go type mapping for new timestamp fields from #95 #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
452112b
Add Go type mapping for new timestamp fields from #95
yurishkuro Sep 10, 2023
a226304
fix
yurishkuro Sep 10, 2023
a741d4d
import
yurishkuro Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions proto/api_v2/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,13 @@ message GetTraceRequest {
(gogoproto.customname) = "TraceID"
];
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2;
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3;
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
];
}

message SpansResponseChunk {
Expand All @@ -59,9 +63,13 @@ message ArchiveTraceRequest {
(gogoproto.customname) = "TraceID"
];
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2;
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3;
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
];
}

message ArchiveTraceResponse {
Expand Down
9 changes: 7 additions & 2 deletions proto/api_v3/query_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ syntax="proto3";
package jaeger.api_v3;

import "opentelemetry/proto/trace/v1/trace.proto";
import "gogoproto/gogo.proto";
import "google/protobuf/timestamp.proto";
import "google/protobuf/duration.proto";

Expand All @@ -28,9 +29,13 @@ message GetTraceRequest {
// Hex encoded 64 or 128 bit trace ID.
string trace_id = 1;
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2;
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3;
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
];
}

// Response object with spans.
Expand Down
Loading