added all-in-one deployment and configmap for jaeger-v2 #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehul <[email protected]>
Signed-off-by: Mehul <[email protected]>
yurishkuro
reviewed
Oct 1, 2024
charts/jaeger-v2/Chart.yaml
Outdated
Comment on lines
11
to
13
| - opentracing | ||
| - tracing | ||
| - instrumentation |
There was a problem hiding this comment.
Suggested change
| - opentracing | |
| - tracing | |
| - instrumentation | |
| - opentelemetry | |
| - tracing |
| helm install jaeger-v2 ./ -f my-config-values.yaml | ||
| ``` | ||
|
|
||
| This command installs the Jaeger chart and uses `my-config-values.yaml` for overriding any configuration specified in the default `values.yaml`. |
There was a problem hiding this comment.
what does "overriding" mean? Does it completely ignore the default file, or performs some sort of merge?
There was a problem hiding this comment.
let's say you have specified
jaeger_storage:
backends:
some_store:
memory:
max_traces: 90000
another_store:
memory:
max_traces: 90000
but didn't specified
remote_sampling:
adaptive:
sampling_store: some_store
initial_sampling_probability: 0.1
so it will use default value of 0.1 from vaules.yaml
charts/jaeger-v2/values.yaml
Outdated
Comment on lines
32
to
34
| adaptive: | ||
| sampling_store: some_store | ||
| initial_sampling_probability: 0.1 |
There was a problem hiding this comment.
I don't think we want adaptive sampling to be the default.
Signed-off-by: Mehul <[email protected]>
Signed-off-by: Mehul <[email protected]>
Signed-off-by: Mehul <[email protected]>
Signed-off-by: Mehul <[email protected]>
Jaeger v2 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue this PR fixes
is a part of jaegertracing/jaeger#5767
Checklist
[jaeger]or[jaeger-operator])