fix 1.6

j-fu · Jan 25, 2024 · 003cb1c · 003cb1c · j-fu · Jan 25, 2024
1 parent e4d871b
commit 003cb1c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 12 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1,4 +1,4 @@
-name: linux-macos-windows
+name: ci
 on:
   pull_request:
     branches:
@@ -17,20 +17,20 @@ jobs:
         version:
           - '1.6' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'.
           - '1'   # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
-          - 'nightly' # currently fails for LinearSolve
+          - 'nightly'
         os:
           - ubuntu-latest
           - macos-latest
           - windows-latest
         arch:
           - x64
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: julia-actions/setup-julia@v1
         with:
           version: ${{ matrix.version }}
           arch: ${{ matrix.arch }}
-      - uses: actions/cache@v1
+      - uses: actions/cache@v4
         env:
           cache-name: cache-artifacts
         with:
@@ -43,14 +43,12 @@ jobs:
       - uses: julia-actions/julia-buildpkg@v1
       - uses: julia-actions/julia-runtest@v1
       - uses: julia-actions/julia-processcoverage@v1
-      - uses: codecov/codecov-action@v1
-        with:
-          file: lcov.info
+      - uses: codecov/codecov-action@v3
   docs:
     name: Documentation
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: julia-actions/setup-julia@v1
         with:
           version: '1'

diff --git a/src/matrix/sparsematrixcsc.jl b/src/matrix/sparsematrixcsc.jl
@@ -95,7 +95,10 @@ end
 Return boolean vector marking Dirichlet nodes, known by `A[i,i]>=penalty`
 """
 function mark_dirichlet(A::SparseMatrixCSC; penalty=1.0e20)
-    (;colptr,rowval,nzval,n)=A
+    colptr=A.colptr
+    rowval=A.rowval
+    nzval=A.nzval
+    n=A.n
     dirichlet=zeros(Bool,n)
     for i=1:n
         for j=colptr[i]:colptr[i+1]-1
@@ -119,7 +122,10 @@ for a node `i` marked as Dirichlet.
 Returns A.
 """
 function eliminate_dirichlet!(A::SparseMatrixCSC,dirichlet)
-    (;colptr,rowval,nzval,n)=A
+    colptr=A.colptr
+    rowval=A.rowval
+    nzval=A.nzval
+    n=A.n
     for i=1:n
         # set off-diagonal column indiced to zero
         if !iszero(dirichlet[i])
@@ -154,7 +160,6 @@ for a node `i` marked as Dirichlet.
 Returns B.
 """
 function eliminate_dirichlet(A::SparseMatrixCSC,dirichlet)
-    (;m,n,colptr,rowval,nzval)=A
-    B=SparseMatrixCSC(m,n,colptr,rowval,copy(nzval))
+    B=SparseMatrixCSC(A.m,A.n,A.colptr,A.rowval,copy(A.nzval))
     eliminate_dirichlet!(B,dirichlet)
 end