Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for DynamicPPL to 0.26, (keep existing compat) #68

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 9, 2024

This pull request changes the compat entry for the DynamicPPL package from 0.22.0,0.23.0,0.24.0 to 0.22.0,0.23.0,0.24.0, 0.26.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@itsdfish itsdfish closed this May 9, 2024
@itsdfish itsdfish reopened this May 9, 2024
Copy link
Contributor Author

github-actions bot commented May 9, 2024

Benchmark Results

master df35741... master/df357419cbacb1...
logpdf/("SequentialSamplingModels.DDM", 10) 1.67 ± 0.12 μs 1.66 ± 0.12 μs 1
logpdf/("SequentialSamplingModels.DDM", 100) 17.4 ± 0.81 μs 17.3 ± 0.82 μs 1
logpdf/("SequentialSamplingModels.LBA", 10) 2.45 ± 0.2 μs 2.45 ± 0.18 μs 1
logpdf/("SequentialSamplingModels.LBA", 100) 23.4 ± 0.65 μs 23.4 ± 0.64 μs 1
logpdf/("SequentialSamplingModels.LNR", 10) 0.997 ± 0.14 μs 0.996 ± 0.15 μs 1
logpdf/("SequentialSamplingModels.LNR", 100) 8.62 ± 0.29 μs 8.6 ± 0.29 μs 1
logpdf/("SequentialSamplingModels.RDM", 10) 2.57 ± 0.19 μs 2.57 ± 0.19 μs 0.998
logpdf/("SequentialSamplingModels.RDM", 100) 25.1 ± 0.72 μs 25 ± 0.73 μs 1
logpdf/("SequentialSamplingModels.Wald", 10) 0.227 ± 0.16 μs 0.226 ± 0.16 μs 1
logpdf/("SequentialSamplingModels.Wald", 100) 2.09 ± 0.14 μs 2.07 ± 0.14 μs 1.01
logpdf/("SequentialSamplingModels.WaldMixture", 10) 1.08 ± 0.16 μs 1.08 ± 0.16 μs 1
logpdf/("SequentialSamplingModels.WaldMixture", 100) 10.6 ± 0.16 μs 10.6 ± 0.18 μs 0.999
rand/("SequentialSamplingModels.DDM", 10) 3.92 ± 0.56 μs 3.93 ± 0.56 μs 0.997
rand/("SequentialSamplingModels.DDM", 100) 0.0385 ± 0.002 ms 0.0384 ± 0.002 ms 1
rand/("SequentialSamplingModels.LBA", 10) 3.25 ± 0.32 μs 3.27 ± 0.33 μs 0.992
rand/("SequentialSamplingModels.LBA", 100) 16.5 ± 0.53 μs 16.4 ± 0.45 μs 1
rand/("SequentialSamplingModels.LCA", 10) 0.767 ± 0.25 ms 0.761 ± 0.25 ms 1.01
rand/("SequentialSamplingModels.LCA", 100) 8.35 ± 0.24 ms 8.2 ± 0.31 ms 1.02
rand/("SequentialSamplingModels.LNR", 10) 1.1 ± 0.45 μs 1.1 ± 0.45 μs 1
rand/("SequentialSamplingModels.LNR", 100) 7.65 ± 3.8 μs 7.58 ± 3.9 μs 1.01
rand/("SequentialSamplingModels.RDM", 10) 1.38 ± 0.43 μs 1.37 ± 0.44 μs 1.01
rand/("SequentialSamplingModels.RDM", 100) 11.1 ± 3.8 μs 11.1 ± 3.9 μs 0.994
rand/("SequentialSamplingModels.Wald", 10) 0.464 ± 0.16 μs 0.458 ± 0.16 μs 1.01
rand/("SequentialSamplingModels.Wald", 100) 2.89 ± 0.2 μs 2.91 ± 0.21 μs 0.993
rand/("SequentialSamplingModels.WaldMixture", 10) 1.18 ± 0.15 μs 1.18 ± 0.15 μs 0.997
rand/("SequentialSamplingModels.WaldMixture", 100) 11.3 ± 0.2 μs 11.3 ± 0.21 μs 0.999
simulate/SequentialSamplingModels.DDM 3.75 ± 1.6 μs 3.69 ± 1.6 μs 1.02
simulate/SequentialSamplingModels.LBA 3.76 ± 0.4 μs 3.73 ± 0.39 μs 1.01
simulate/SequentialSamplingModels.LCA 0.103 ± 0.022 ms 0.101 ± 0.019 ms 1.02
simulate/SequentialSamplingModels.RDM 0.102 ± 0.035 ms 0.0966 ± 0.031 ms 1.05
simulate/SequentialSamplingModels.Wald 9.37 ± 4.7 μs 9.44 ± 4.8 μs 0.993
simulate/SequentialSamplingModels.WaldMixture 4.05 ± 1.6 μs 3.99 ± 1.6 μs 1.02
time_to_load 3.73 ± 0.041 s 3.69 ± 0.0082 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@itsdfish itsdfish closed this May 9, 2024
@itsdfish itsdfish deleted the compathelper/new_version/2024-05-09-01-13-40-141-00360953915 branch July 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant