User roles - Initial #964
Merged
User roles - Initial #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the default user roles into the database to make way for custom roles & permissions
|
Test these changes at: https://userrolesinitial964.pr-review.itflow.org |
|
|
This looks great!! Code is clean, can't seem to find any where this might break pulling in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the default user roles into the database to make way for custom roles & permissions.
Please could you take a look, test, and let me know your thoughts?
Following from this, I'd like to create a role_permissions table where we then re-create the default permissions that we have in the code in the database. Once all that is complete, we can then open up to editing the built-in roles / allowing custom roles and permissions.