Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies #4930

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Remove unused dependencies #4930

merged 3 commits into from
Oct 31, 2023

Conversation

sroy3
Copy link
Contributor

@sroy3 sroy3 commented Oct 30, 2023 •
edited
Loading

depcheks will still return:

Unused devDependencies
* @vscode/codicons
* eslint-plugin-n
* eslint-plugin-promise
* lint-staged
* prettier

Those are all used dependencies

@sroy3 sroy3 self-assigned this Oct 30, 2023
@sroy3 sroy3 marked this pull request as ready for review October 30, 2023 14:09
mattseddon
mattseddon reviewed Oct 30, 2023
View reviewed changes
package.json
@@ -61,7 +60,6 @@
"lint-staged": "14.0.1",
"npm-run-all": "4.1.5",
"nyc": "15.1.0",
"postcss": "8.4.31",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Does stylelint definitely not require this? @julieg18 was the one who added it, maybe she remembers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not getting any errors or warnings when running yarn lint:css. I'll wait on @julieg18 to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think stylelint requires it. It should work correctly without it. My guess is I accidentally added it when I was running get started scripts or I added it when I was troubleshooting.

julieg18
julieg18 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sroy3 sroy3 enabled auto-merge (squash) October 31, 2023 13:53
@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 31, 2023

Code Climate has analyzed commit b041378 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1% (0.0% change).

View more on Code Climate.

@sroy3 sroy3 merged commit 84c498d into main Oct 31, 2023
8 checks passed
@sroy3 sroy3 deleted the remove-unused-dependencies branch October 31, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattseddon mattseddon mattseddon approved these changes

@julieg18 julieg18 julieg18 approved these changes

Assignees

@sroy3 sroy3

Labels
🏠 housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sroy3 @mattseddon @julieg18