Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add created branch (from dvc exp branch) to the experiments table #4857

Merged
merged 10 commits into from
Oct 25, 2023

Conversation

julieg18
Copy link
Contributor

@julieg18 julieg18 commented Oct 18, 2023

  • If a user creates a new branch using the extension, we add the newly created branch (if it exists) to the table

Demo

Screen.Recording.2023-10-18.at.5.21.09.PM.mov

Fixes https://iterativeai.slack.com/archives/C01APS0FHDM/p1697466359466489?thread_ts=1697456789.149749&cid=C01APS0FHDM

@julieg18 julieg18 added the product PR that affects product label Oct 18, 2023
@julieg18 julieg18 self-assigned this Oct 18, 2023
extension/src/experiments/webview/messages.ts Outdated Show resolved Hide resolved
extension/src/experiments/workspace.ts Outdated Show resolved Hide resolved
@julieg18 julieg18 marked this pull request as ready for review October 18, 2023 22:31
Copy link
Member

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sold on the utility of this. A few months ago we started moving away from auto-magical behaviour as it unnecessarily complicates the code and leads to unexpected behaviour for users.

extension/src/experiments/webview/messages.ts Outdated Show resolved Hide resolved
extension/src/experiments/webview/messages.ts Outdated Show resolved Hide resolved
extension/src/experiments/workspace.ts Outdated Show resolved Hide resolved
extension/src/experiments/webview/messages.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@sroy3 sroy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

I'm not expecting what I will say next to be added to this PR. It could be a follow-up for later on if we agree on it.
I feel like there is a good amount of time passing between when we create the branch, when we show the toast and when we add the branch.
It is a lot more advanced, but having some sort of loading at the bottom of the table from the time the user creates the branch to when we add the branch would feel less confusing for the user. Some message that says "branch-name is being added to the table."

@julieg18 julieg18 changed the title Add created branch (from "Create New Branch" context menu action) to experiments table Add created branch (from dvc exp branch) to the experiments table Oct 24, 2023
@julieg18
Copy link
Contributor Author

I feel like there is a good amount of time passing between when we create the branch, when we show the toast and when we add the branch.

@sroy3 , with the latest change (only needing to run an update once), the table runs a lot faster. Plus, my computer tends to run on the slower side. If you have a chance, could you test this feature out with the newest changes? If it feels slow, I can work on adding a Toast message that says something like Adding branch to table... at the very least.

@julieg18 julieg18 enabled auto-merge (squash) October 25, 2023 13:18
@sroy3
Copy link
Contributor

sroy3 commented Oct 25, 2023

I feel like there is a good amount of time passing between when we create the branch, when we show the toast and when we add the branch.

@sroy3 , with the latest change (only needing to run an update once), the table runs a lot faster. Plus, my computer tends to run on the slower side. If you have a chance, could you test this feature out with the newest changes? If it feels slow, I can work on adding a Toast message that says something like Adding branch to table... at the very least.

It does work almost instantly. Great work!

@codeclimate
Copy link

codeclimate bot commented Oct 25, 2023

Code Climate has analyzed commit 59e7445 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0%.

View more on Code Climate.

@julieg18 julieg18 merged commit e557145 into main Oct 25, 2023
8 checks passed
@julieg18 julieg18 deleted the add-newly-created-branch-to-table branch October 25, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants