Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move to start option to experiment table header cell context menu #4303

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 19, 2023

1/2 main <- this <- #4304

Related to #4229

This PR adds a "Move to Start" option to the experiments table header cell context menu.

Demo

Screen.Recording.2023-07-19.at.10.43.27.am.mov

@mattseddon mattseddon added the product PR that affects product label Jul 19, 2023
@mattseddon mattseddon self-assigned this Jul 19, 2023
@@ -102,6 +102,15 @@ export const getMenuOptions = (
type: MessageFromWebviewType.HIDE_EXPERIMENTS_TABLE_COLUMN
}
},
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@mattseddon mattseddon enabled auto-merge (squash) July 19, 2023 22:14
@codeclimate
Copy link

codeclimate bot commented Jul 19, 2023

Code Climate has analyzed commit a7ed31f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.1% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 9d70e6f into main Jul 19, 2023
6 checks passed
@mattseddon mattseddon deleted the add-move-to-start branch July 19, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants