Add columns indicator (select columns) to table indicators #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jul 18, 2023
| @@ -1584,136 +1584,178 @@ describe('App', () => { | |||
| expect(sortIndicator).toHaveTextContent('2') | |||
| jest.useRealTimers() | |||
| }) | |||
| }) | |||
There was a problem hiding this comment.
[F] The describe block shouldn't have ended here. I'll mark the new test(s).
mattseddon
commented
Jul 18, 2023
| expect(mockPostMessage).toHaveBeenCalledWith({ | ||
| type: MessageFromWebviewType.FOCUS_FILTERS_TREE | ||
|
|
||
| it('should show an indicator with the amount of displayed columns', () => { |
There was a problem hiding this comment.
[F] last two tests are new
mattseddon
force-pushed
the
add-select-columns
branch
from
21b2a3c
to
07f8adb
Compare
mattseddon
commented
Jul 18, 2023
| @@ -123,6 +134,15 @@ export const Indicators = () => { | |||
| > | |||
| <Icon width={16} height={16} icon={GitMerge} /> | |||
| </Indicator> | |||
| <Indicator | |||
There was a problem hiding this comment.
[F] Considered making this the first indicator. Decided against it. Happy to update if you have a different opinion.
julieg18
approved these changes
Jul 18, 2023
mattseddon
force-pushed
the
add-select-columns
branch
from
07f8adb
to
cca8860
Compare
|
Code Climate has analyzed commit cca8860 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4269 & #4229
This PR adds a columns indicator icon to the experiment table indicators. Clicking on the indicator icon will trigger the
Select Columns to Display in the Experiments Tablequick pick.Demo
Screen.Recording.2023-07-18.at.11.56.35.am.mov
Note: I am also planning to add a "Move Columns To Start" or "Move Columns Left" quick pick.