Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DVCLive snippets #4258

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Add DVCLive snippets #4258

merged 2 commits into from
Jul 11, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 11, 2023 •
edited
Loading

This PR adds DVCLive snippets for Catalyst, Fast.ai, Hugging Face, Keras, LightGBM, Optuna, Pytorch Lightning & XGBoost. The other examples seem too involved to be useful as snippets (the omitted frameworks are MMCV, Pytorch & TensorFlow)

I have also added a note to the <DVCLiveExamples /> component which mentions the existence of these snippets.

Demo

Screen.Recording.2023-07-11.at.2.36.49.pm.mov

cc @daavoo (feedback appreciated)

@mattseddon mattseddon added the product PR that affects product label Jul 11, 2023
@mattseddon mattseddon self-assigned this Jul 11, 2023
@mattseddon mattseddon force-pushed the add-dvclive-snippets branch 2 times, most recently from 45f6466 to 7da658d Compare July 11, 2023 04:57
@mattseddon mattseddon marked this pull request as ready for review July 11, 2023 04:58
daavoo
daavoo approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@daavoo daavoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dberenbaum I don't know if it would make a difference but maybe we should invest in having some consistent, minimally usable snippets across docs/products.

Feels like we differ too much from Lightning being almost copy-pasteable and others like Keras being too far from usable

julieg18
julieg18 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dberenbaum
Copy link
Contributor

Thanks @daavoo! Let's make it part of https://iterative-squad.monday.com/boards/2546688237

@mattseddon
Copy link
Member Author

Contributions are welcome when the snippets get updated 😅 🙏🏻.

@mattseddon mattseddon enabled auto-merge (squash) July 11, 2023 22:24
@codeclimate
Copy link

codeclimate bot commented Jul 11, 2023

Code Climate has analyzed commit 8246a4a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 2ca6258 into main Jul 11, 2023
3 checks passed
@mattseddon mattseddon deleted the add-dvclive-snippets branch July 11, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daavoo daavoo daavoo approved these changes

@julieg18 julieg18 julieg18 approved these changes

@sroy3 sroy3 Awaiting requested review from sroy3

@shcheklein shcheklein Awaiting requested review from shcheklein shcheklein is a code owner

Assignees

@mattseddon mattseddon

Labels
product PR that affects product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattseddon @dberenbaum @daavoo @julieg18