Further reduce the number of calls to Git #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Jun 22, 2023
| this.dvcRoot | ||
| ) | ||
| ]) | ||
| const allBranches = await this.internalCommands.executeCommand<string[]>( |
There was a problem hiding this comment.
[F] I realised that this did not make sense when digging further into the underlying calls/logic.
There was a problem hiding this comment.
I should have picked this up earlier.
mattseddon
force-pushed
the
reduce-number-git-calls
branch
from
ab855b3
to
ba32386
Compare
julieg18
approved these changes
Jun 22, 2023
mattseddon
force-pushed
the
reduce-number-git-calls
branch
from
ba32386
to
6c5f1ef
Compare
|
Code Climate has analyzed commit 6c5f1ef and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4111
This PR further reduce the number of calls that we make to Git. It does this by moving the git branch parsing logic out of the
GitReaderclass and into theExperimentsModel.This is some prework for the issue/fix detailed here.
Edit: Adding a fix for the issue may not be required.