Add CSS selector & variable naming rules #4162
Conversation
julieg18
changed the title
| @@ -10,8 +10,13 @@ module.exports = { | |||
| true, | |||
| { ignorePseudoClasses: ['global'] } | |||
| ], | |||
| 'custom-property-pattern': null, | |||
| 'selector-class-pattern': null, | |||
| 'selector-class-pattern': [ | |||
There was a problem hiding this comment.
Set our selectors to camelCase and our variables to be kebab-case. We can also set our variables to be camelCase as well if preferred.
I vote we avoid combining the two like vscode does though.
| @@ -826,6 +826,6 @@ $badge-size: 0.85rem; | |||
|
|
|||
| p { | |||
| opacity: 0.6; | |||
| font-family: var(--vscode-font-family); | |||
There was a problem hiding this comment.
Moved all vscode variables to variables.scss since some VSCode variables use a combination of camelCase and kebab-case which need a disabling rule. Plus I think it makes it easier to reuse/edit variables in general.
| @@ -1,7 +1,7 @@ | |||
| import { Config } from 'vega-lite' | |||
|
|
|||
| const foregroundColor = 'var(--vscode-editor-foreground)' | |||
| const backgroundColor = 'var(--vscode-editor-foreground-transparency-1)' | |||
There was a problem hiding this comment.
vscode-editor-foreground-transparency-1 actually isn't a real variable. It still ended up working though since all we needed to do in the config was undo the default white color.
|
Code Climate has analyzed commit a942a14 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
Part of #3760