Rename firstThreeColumns
#4159
Merged
Rename firstThreeColumns
#4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieg18
commented
Jun 21, 2023
| @@ -282,7 +282,7 @@ describe('ColumnsModel', () => { | |||
| ) | |||
| await model.transformAndSet(outputFixture) | |||
|
|
|||
| expect(model.getFirstThreeColumnOrder()).toStrictEqual([ | |||
| expect(model.getSummaryColumnOrder()).toStrictEqual([ | |||
There was a problem hiding this comment.
Figured that summaryColumns is simpler than firstThreeMetricAndParamColumns. Plus, if we adjust what these summary columns include we won't need to nename everything again. Though there might be a better term than summary.
mattseddon
approved these changes
Jun 21, 2023
…irst-three-columns
julieg18
merged commit dc4c32f
into
use-metrics-and-params-in-table-tooltips
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main<= #4155 <= thisfirstThreeColumns(and related variables/keys) tosummaryColumnsFollowup to #4135 (review)