Fix Created column presence in show only changed (#4435)

iterative · Aug 8, 2023 · 8fd01d7 · 8fd01d7
1 parent b7a6c51
commit 8fd01d7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/extension/src/experiments/columns/collect/index.test.ts b/extension/src/experiments/columns/collect/index.test.ts
@@ -543,6 +543,7 @@ describe('collectColumnsWithChangedValues', () => {
     expect(changedColumns).toStrictEqual(
       columnsFixture.filter(({ path }) =>
         [
+          'Created',
           'metrics:summary.json',
           'metrics:summary.json:loss',
           'metrics:summary.json:accuracy',

diff --git a/extension/src/experiments/columns/collect/index.ts b/extension/src/experiments/columns/collect/index.ts
@@ -6,7 +6,7 @@ import {
   collectMetricAndParamChanges,
   collectMetricsAndParams
 } from './metricsAndParams'
-import { Column, Commit, Experiment } from '../../webview/contract'
+import { Column, ColumnType, Commit, Experiment } from '../../webview/contract'
 import { getValue } from '../util'
 import {
   ExpRange,
@@ -167,7 +167,12 @@ const collectChangedPaths = (
   records: (Commit | Experiment)[]
 ) => {
   const acc: string[] = []
-  for (const { pathArray, path, hasChildren } of columns) {
+  for (const { type, pathArray, path, hasChildren } of columns) {
+    if (type === ColumnType.TIMESTAMP) {
+      collectChangedPath(acc, path, [path], records)
+      continue
+    }
+
     if (!pathArray || hasChildren) {
       continue
     }