Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper machine type parity with task #718

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Helper machine type parity with task #718

merged 1 commit into from
Nov 15, 2022

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Nov 14, 2022

fixes iterative/cml#1145

Task helpers:

sizes := map[string]string{
"s": "t2.micro",
"m": "m5.2xlarge",
"l": "m5.8xlarge",
"xl": "m5.16xlarge",
"m+t4": "g4dn.xlarge",
"m+k80": "p2.xlarge",
"l+k80": "p2.8xlarge",
"xl+k80": "p2.16xlarge",
"m+v100": "p3.xlarge",
"l+v100": "p3.8xlarge",
"xl+v100": "p3.16xlarge",
}

sizes := map[string]string{
"s": "Standard_B1s",
"m": "Standard_F8s_v2",
"l": "Standard_F32s_v2",
"xl": "Standard_F64s_v2",
"m+t4": "Standard_NC4as_T4_v3",
"m+k80": "Standard_NC6",
"l+k80": "Standard_NC12",
"xl+k80": "Standard_NC24",
"m+v100": "Standard_NC6s_v3",
"l+v100": "Standard_NC12s_v3",
"xl+v100": "Standard_NC24s_v3",
}

sizes := map[string]string{
"s": "g1-small",
"m": "e2-custom-8-32768",
"l": "e2-custom-32-131072",
"xl": "n2-custom-64-262144",
"m+t4": "n1-standard-4+nvidia-tesla-t4*1",
"m+k80": "custom-8-53248+nvidia-tesla-k80*1",
"l+k80": "custom-32-131072+nvidia-tesla-k80*4",
"xl+k80": "custom-64-212992-ext+nvidia-tesla-k80*8",
"m+v100": "custom-8-65536-ext+nvidia-tesla-v100*1",
"l+v100": "custom-32-262144-ext+nvidia-tesla-v100*4",
"xl+v100": "custom-64-524288-ext+nvidia-tesla-v100*8",
}

@dacbd dacbd requested a review from a team November 14, 2022 16:55
@dacbd dacbd self-assigned this Nov 14, 2022
Copy link
Contributor

@tasdomas tasdomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of the map[string]map[string]map[string]string contraption

iterative/aws/provider.go Show resolved Hide resolved
iterative/azure/provider.go Show resolved Hide resolved
iterative/gcp/provider.go Show resolved Hide resolved
@dacbd
Copy link
Contributor Author

dacbd commented Nov 15, 2022

@tasdomas If you are good with my comments I'll open a separate issue for these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generic --cloud-type not working
3 participants