Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource tagging support #599

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Add resource tagging support #599

merged 2 commits into from
Jun 2, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jun 2, 2022 •
edited
Loading 

resource "iterative_task" "example" {
  ···
  tags = {
    Something = "Useful"
  }
}

Closes #598

@0x2b3bfa0 0x2b3bfa0 linked an issue Jun 2, 2022 that may be closed by this pull request
Allow setting instance tags for cloud providers #598
Closed
@0x2b3bfa0 0x2b3bfa0 requested a review from a team June 2, 2022 13:54
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jun 2, 2022
@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request cloud-common Applies to every cloud vendor labels Jun 2, 2022
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 2, 2022
Closed
casperdcl
casperdcl suggested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/resources/task.md Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl June 2, 2022 14:17
@dacbd
Copy link
Contributor

dacbd commented Jun 2, 2022

I go to bed and he beats me to it 😆

@0x2b3bfa0
Copy link
Member Author

he beats me to it

Sleeping, or opening pull requests? 🦦

@dacbd
Copy link
Contributor

dacbd commented Jun 2, 2022

I might be being extra picky but for AWS as the example, the auto-scaling group doesn't get the tag, and more importantly, s3 objects are missing them as well.

@0x2b3bfa0 0x2b3bfa0 merged commit d6e4a29 into master Jun 2, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the 598-allow-setting-instance-tags-for-cloud-providers branch June 2, 2022 18:55
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jun 2, 2022
Open
@0x2b3bfa0
Copy link
Member Author

You're picky and it's awesome! 🙏🏼 Tracking this on #601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cloud-common Applies to every cloud vendor enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting instance tags for cloud providers
3 participants
@0x2b3bfa0 @dacbd @casperdcl