Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI consistency: --native => --publish-native #1210

Merged
merged 6 commits into from
Oct 14, 2022
Merged

CLI consistency: --native => --publish-native #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26e815a
--native => --publish-native
casperdcl Oct 7, 2022
ec4204e
cleanup pr <glob path>
casperdcl Oct 7, 2022
3c34b28
Merge branch 'master' into cli-updates
0x2b3bfa0 Oct 11, 2022
ffc132d
Revert "cleanup pr <glob path>"
casperdcl Oct 14, 2022
90238b7
reorder again
casperdcl Oct 14, 2022
7c204f4
Merge branch 'master' into cli-updates
0x2b3bfa0 Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions bin/cml/comment/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@ exports.options = kebabcaseKeys({
default: 'HEAD',
description: 'Commit SHA linked to this comment'
},
watch: {
casperdcl marked this conversation as resolved.
Show resolved Hide resolved
type: 'boolean',
description: 'Watch for changes and automatically update the comment'
},
triggerFile: {
type: 'string',
description: 'File used to trigger the watcher',
hidden: true
},
publish: {
type: 'boolean',
default: true,
Expand All @@ -37,17 +46,9 @@ exports.options = kebabcaseKeys({
description: 'Self-hosted image server URL',
telemetryData: 'name'
},
watch: {
type: 'boolean',
description: 'Watch for changes and automatically update the comment'
},
triggerFile: {
type: 'string',
description: 'File used to trigger the watcher',
hidden: true
},
native: {
publishNative: {
type: 'boolean',
alias: 'native',
description:
"Uses driver's native capabilities to upload assets instead of CML's storage; not available on GitHub",
telemetryData: 'name'
Expand Down
24 changes: 12 additions & 12 deletions bin/cml/comment/create.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,21 @@ describe('Comment integration tests', () => {
--help Show help [boolean]

Options:
--pr Post to an existing PR/MR associated with the
specified commit [boolean]
--commit-sha, --head-sha Commit SHA linked to this comment
--pr Post to an existing PR/MR associated with the
specified commit [boolean]
--commit-sha, --head-sha Commit SHA linked to this comment
[string] [default: \\"HEAD\\"]
--publish Upload any local images found in the Markdown report
[boolean] [default: true]
--publish-url Self-hosted image server URL
--watch Watch for changes and automatically update the
comment [boolean]
--publish Upload any local images found in the Markdown
report [boolean] [default: true]
--publish-url Self-hosted image server URL
[string] [default: \\"https://asset.cml.dev\\"]
--watch Watch for changes and automatically update the
comment [boolean]
--native Uses driver's native capabilities to upload assets
instead of CML's storage; not available on GitHub
--publish-native, --native Uses driver's native capabilities to upload assets
instead of CML's storage; not available on GitHub
[boolean]
--rm-watermark Avoid watermark; CML needs a watermark to be able to
distinguish CML comments from others [boolean]"
--rm-watermark Avoid watermark; CML needs a watermark to be able
to distinguish CML comments from others [boolean]"
`);
});
});