Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release workflow #1181

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Fix release workflow #1181

merged 3 commits into from
Sep 22, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Sep 22, 2022 •
edited
Loading

Partial revert of #1165; cml pr doesn't work like that.

@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review September 22, 2022 16:47
@0x2b3bfa0
Copy link
Member Author

Self-merging because it also fixes required checks. 🙈

@0x2b3bfa0 0x2b3bfa0 merged commit cb8c882 into master Sep 22, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the fix-release branch September 22, 2022 16:52
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Sep 22, 2022
Merged
@casperdcl
Copy link
Contributor

pity, shouldn't this be a valid use case of cml pr? Follow-up feature request?

@casperdcl casperdcl added technical-debt Refactoring, linting & tidying releases Shipping builds labels Sep 23, 2022
@0x2b3bfa0
Copy link
Member Author

Indeed! Feel free

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Sep 28, 2022
Merged
@casperdcl casperdcl mentioned this pull request Oct 3, 2022
Closed
@dacbd dacbd mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
releases Shipping builds technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @casperdcl